This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Fill with -1 instead of nan when dtype is integer#13
Open
fanurs wants to merge 1 commit intocasangi:masterfrom
Open
Fill with -1 instead of nan when dtype is integer#13fanurs wants to merge 1 commit intocasangi:masterfrom
fanurs wants to merge 1 commit intocasangi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! While learning about the prototype, I encountered an error when running the Data Structures Colab notebook:
The error comes from the following line:
cngi_prototype/cngi/_utils/_table_conversion2.py
Line 365 in 920580a
Specifically, because
assoc_spw_idhas a dtype of integer, it is impossible to fill it withnp.nan.I am not very familiar with the context of these data, but a quick fix would be to fill it with, say,
-1(in this PR), or to simply convert the dtype into float.